[Java] Use AeronEvent when logging onPublicationError and add additio…

…nal parameters.
G-Research · Dec 16, 2024 · 8efa0e7 · 8efa0e7
1 parent 8ac261b
commit 8efa0e7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/aeron-client/src/main/java/io/aeron/status/PublicationErrorFrame.java b/aeron-client/src/main/java/io/aeron/status/PublicationErrorFrame.java
@@ -29,7 +29,7 @@ public class PublicationErrorFrame implements Cloneable
     private int streamId;
     private long receiverId;
     private long destinationRegistrationId;
-    private Long groupTag;
+    private long groupTag;
     private int errorCode;
     private String errorMessage;
     private InetSocketAddress sourceAddress;
@@ -77,10 +77,10 @@ public long receiverId()
     /**
      * Group tag of the source that sent the error frame.
      *
-     * @return group tag of the source that sent the error frame, <code>null</code> if the source did not have a group
+     * @return group tag of the source that sent the error frame or {@link io.aeron.Aeron#NULL_VALUE} if the source did not have a group
      * tag set.
      */
-    public Long groupTag()
+    public long groupTag()
     {
         return groupTag;
     }

diff --git a/aeron-driver/src/main/java/io/aeron/driver/DriverConductor.java b/aeron-driver/src/main/java/io/aeron/driver/DriverConductor.java
@@ -394,12 +394,22 @@ void onPublicationError(
         final int sessionId,
         final int streamId,
         final long receiverId,
-        final Long groupId,
+        final long groupId,
         final InetSocketAddress srcAddress,
         final int errorCode,
         final String errorMessage)
     {
-        recordError(new AeronException(errorMessage, AeronException.Category.WARN));
+        recordError(new AeronEvent(
+            "onPublicationError: " +
+            "registrationId=" + registrationId +
+            ", destinationRegistrationId=" + destinationRegistrationId +
+            ", sessionId=" + sessionId +
+            ", streamId=" + streamId +
+            ", receiverId=" + receiverId +
+            ", groupId=" + groupId +
+            ", errorCode=" + errorCode +
+            ", errorMessage=" + errorMessage,
+            AeronException.Category.WARN));
         clientProxy.onPublicationErrorFrame(
             registrationId,
             destinationRegistrationId,

diff --git a/aeron-driver/src/main/java/io/aeron/driver/DriverConductorProxy.java b/aeron-driver/src/main/java/io/aeron/driver/DriverConductorProxy.java
@@ -253,7 +253,7 @@ void onPublicationError(
         final int sessionId,
         final int streamId,
         final long receiverId,
-        final Long groupId,
+        final long groupId,
         final InetSocketAddress srcAddress,
         final int errorCode,
         final String errorMessage)