Improve Docker image building #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiannuzzi
force-pushed
the
docker-cache
branch
2 times, most recently
from
d4e71d9
to
5823e12
Compare
We use the built binary and copy it into the image instead of rebuilding it, which allows us to take advantage of minimal and effective caching. The images for the various architectures are built in parallel and merged during registry upload.
jgiannuzzi
force-pushed
the
docker-cache
branch
from
5823e12
to
189b5ff
Compare
suprjinx
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fourth in a series to address #328.
It changes the way we build the Docker images by using the built binary and copying it into the image instead of rebuilding it. This allows us to take advantage of minimal and effective caching. The images for the various architectures are now built in parallel and merged during the push to the registry.