Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff similar DataFrames with ignoreColumns #111

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Sep 7, 2022

With ignore columns, diffing allows for different Dataset types.

Fixes #108.

@EnricoMi EnricoMi marked this pull request as draft September 7, 2022 13:18
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Test Results

   106 files  ±  0     106 suites  ±0   21m 24s ⏱️ +53s
   340 tests +  7     340 ✔️ +  7  0 💤 ±0  0 ±0 
3 264 runs  +70  3 264 ✔️ +70  0 💤 ±0  0 ±0 

Results for commit 853ea7e. ± Comparison against base commit bceea91.

This pull request removes 2 and adds 9 tests. Note that renamed tests count towards both.
uk.co.gresearch.spark.diff.DiffSuite ‑ diff with different number of column
uk.co.gresearch.spark.diff.DiffSuite ‑ diffWith ignored
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored column and different number of columns
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored columns
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored columns and empty schema
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored columns case-insensitive
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored columns case-sensitive
uk.co.gresearch.spark.diff.DiffSuite ‑ diff similar with ignored columns of different type
uk.co.gresearch.spark.diff.DiffSuite ‑ diff with different number of columns
uk.co.gresearch.spark.diff.DiffSuite ‑ diff with ignored columns of different types
uk.co.gresearch.spark.diff.DiffSuite ‑ diff with no id columns ids taken from left

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi marked this pull request as ready for review September 13, 2022 09:57
@EnricoMi
Copy link
Contributor Author

@btt3165 ignore columns allow to diff "similar" Dataset[T] and Dataset[U], not just identical Dataset[T] and Dataset[T].

What do you think of this generalization?

@EnricoMi EnricoMi merged commit 36c4f1f into master Oct 26, 2022
@EnricoMi EnricoMi deleted the branch-diff-similar-types branch October 26, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for extra columns on either side if they are ignored
1 participant