Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python API calling into Scala code #132

Merged
merged 11 commits into from
Dec 8, 2022
Merged

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Dec 7, 2022

Running the tests via spark-submit after installing the built package uncovered some issues with the Python API.

Fixes issues like

py4j.protocol.Py4JJavaError: An error occurred while calling z:java.lang.Class.forName.
: java.lang.ClassNotFoundException: uk.co.gresearch.spark.UnpersistHandle$
	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
	at py4j.Gateway.invoke(Gateway.java:282)
	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
	at py4j.commands.CallCommand.execute(CallCommand.java:79)
	at py4j.GatewayConnection.run(GatewayConnection.java:238)
	at java.lang.Thread.run(Thread.java:750)

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Test Results

     364 files  +  42       364 suites  +42   1h 22m 2s ⏱️ + 22m 44s
     441 tests +  38       441 ✔️ +  38  0 💤 ±0  0 ±0 
11 156 runs  +532  11 156 ✔️ +532  0 💤 ±0  0 ±0 

Results for commit 6faf24a. ± Comparison against base commit 02568b8.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi force-pushed the branch-ci-integration-tests branch 5 times, most recently from 50f5b68 to 76f5c69 Compare December 7, 2022 16:34
@EnricoMi EnricoMi marked this pull request as ready for review December 7, 2022 20:11
@EnricoMi EnricoMi changed the title Run tests as integration tests Fix Python API calling into Scala code Dec 7, 2022
@EnricoMi EnricoMi force-pushed the branch-ci-integration-tests branch 2 times, most recently from 914a812 to 050adbd Compare December 8, 2022 08:48
@EnricoMi EnricoMi merged commit 61819cd into master Dec 8, 2022
@EnricoMi EnricoMi deleted the branch-ci-integration-tests branch December 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant