Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map diff comparator to Python API #226

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Jan 24, 2024

This allows for map comparators like DiffComparators.map(Integer(), LongType()) in Python.

Fixes #225.

Copy link

github-actions bot commented Jan 24, 2024

Test Results

   618 files  ±  0     618 suites  ±0   1h 41m 53s ⏱️ +37s
   498 tests +  4     498 ✅ +  4   0 💤 ±0  0 ❌ ±0 
18 960 runs  +160  18 896 ✅ +160  64 💤 ±0  0 ❌ ±0 

Results for commit 4ae5c9c. ± Comparison against base commit 7606d00.

This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both.
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator - keyOrderSensitive=false - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator - keyOrderSensitive=false - codegen enabled=true
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator - keyOrderSensitive=true - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator - keyOrderSensitive=true - codegen enabled=true
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator typed - keyOrderSensitive=false - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator typed - keyOrderSensitive=false - codegen enabled=true
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator typed - keyOrderSensitive=true - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator typed - keyOrderSensitive=true - codegen enabled=true
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator untyped - keyOrderSensitive=false - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator untyped - keyOrderSensitive=false - codegen enabled=true
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator untyped - keyOrderSensitive=true - codegen enabled=false
uk.co.gresearch.spark.diff.DiffComparatorSuite ‑ map comparator untyped - keyOrderSensitive=true - codegen enabled=true

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi merged commit 97ae911 into master Jan 24, 2024
91 checks passed
@EnricoMi EnricoMi deleted the python-diff-map-comparator branch January 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparators error when using pyspark
1 participant