-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of Physionet. #454
base: develop
Are you sure you want to change the base?
Conversation
@@ -9,8 +11,10 @@ | |||
from typing_extensions import Literal | |||
|
|||
import rdata | |||
import skdatasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F401 'skdatasets' imported but unused
@@ -9,8 +11,10 @@ | |||
from typing_extensions import Literal | |||
|
|||
import rdata | |||
import skdatasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
def _physionet_to_fdatagrid( | ||
name: str, | ||
data: DataFrame, | ||
mode: Literal[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS320 Found multi-line function type annotation
) | ||
|
||
|
||
def fetch_physionet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS320 Found multi-line function type annotation
name: str, | ||
*, | ||
return_X_y: bool = False, | ||
as_frame: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
DAR101 Missing parameter(s) in Docstring: - as_frame
|
||
Examples: | ||
>>> import skfda | ||
>>> X, y = skfda.datasets.fetch_physionet("ctu-uhb-ctgdb", return_X_y=True, mode="truncate_right") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
E501 line too long (106 > 79 characters)
skfda/preprocessing/__init__.py
Outdated
from . import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D104 Missing docstring in public package
@@ -0,0 +1 @@ | |||
from ._interpolate import MissingValuesInterpolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D104 Missing docstring in public package
return fdatagrid.copy(data_matrix=data_matrix) | ||
|
||
|
||
class MissingValuesInterpolation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D101 Missing docstring in public class
InductiveTransformerMixin[T, T, Any], | ||
): | ||
|
||
def transform( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D102 Missing docstring in public method
|
||
from ..._utils._sklearn_adapter import BaseEstimator, InductiveTransformerMixin | ||
from ...representation import FDataGrid | ||
from ...representation._typing import GridPoints, NDArrayFloat, NDArrayInt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Cannot find implementation or library stub for module named "skfda.representation._typing" [import]
*, | ||
return_X_y: bool = False, | ||
as_frame: bool = True, | ||
target_column: str | Sequence[str] | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F821 undefined name 'Sequence'
**kwargs: Any, | ||
) -> ( | ||
Bunch | ||
| Tuple[NDArrayAny, NDArrayAny | None] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F821 undefined name 'NDArrayAny'
**kwargs: Any, | ||
) -> ( | ||
Bunch | ||
| Tuple[NDArrayAny, NDArrayAny | None] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F821 undefined name 'NDArrayAny'
No description provided.