UI 자동 바인딩, Resource Manager, Pool Manager #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// Poolable Ŭ�����Դϴ�. ����Ʈ Ǯ��� �� ����տ� �� �����Ʈ�� �ٿ��ָ� �˴ϴ�. | ||
| /// </summary> | ||
| public class Poolable : MonoBehaviour |
There was a problem hiding this comment.
요거는 클래스보다는 인터페이스로 하는게 더 좋을 것 같아요!
There was a problem hiding this comment.
나중에 스킬같은 것들은 자기 부모 클래스 상속받을 것 같아서 인터페이스가 더 유연하게 대처할 수 있을 것 같습니다
There was a problem hiding this comment.
이 클래스가 상속받는게 아니라 컴포넌트로 붙여주는 형식으로 만들어서 굳이 인터페이스로 안해도 되지 않을까?
그냥 프리팹에 부품처럼 따로 붙여주기만 하면 되는거라서
| using UnityEngine; | ||
|
|
||
| /// <summary> | ||
| /// PoolManager Ŭ�����Դϴ�. ���ҽ���� ���մϴ�. |
|
클래스들 Blind 네임스페이스 안으로 넣는게 좋을 것 같습니다 |
dongcheolpark
approved these changes
May 6, 2022
| using UnityEngine; | ||
|
|
||
| /// <summary> | ||
| /// PoolManager Ŭ�����Դϴ�. UI�� ���մϴ�. |
| @@ -43,6 +44,7 @@ private static void Find() | |||
| { | |||
| s_instance = FindObjectOfType<T>(); // 현재 씬에 클래스가 있는지 확인 | |||
| } | |||
|
|
|||
|
|
|||
| protected virtual void Init() { } | |||
There was a problem hiding this comment.
요거는 awake 오버라이드 하면 될 것 같아서 필요 없을듯 합니다
There was a problem hiding this comment.
다른 분들이랑 얘기 해보는 게 좋을 것 같아요
| /// <summary> | ||
| /// Poolable Ŭ�����Դϴ�. ����Ʈ Ǯ��� �� ����տ� �� �����Ʈ�� �ٿ��ָ� �˴ϴ�. | ||
| /// </summary> | ||
| public class Poolable : MonoBehaviour |
dongcheolpark
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.