fix infinite variance handling in GaussEst, DiscreteEst, LinEst and ReLUEst #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The infinite variance handling in GaussEst and DiscreteEst was broken, because it passed avg_var_cost into the ind_out parameter of est_init(). Infinite variance handling was also added to LinEst and the unit tests for all three estimators have been extended to test the infinite variance cases.
The infinite variance code path was broken, because the zhat0_map and related variables did not get set in this code path. The relu unit tests have been extendet to test this code path.
julianwi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infinite variance handling in GaussEst and DiscreteEst was broken, because it passed avg_var_cost into the ind_out parameter of est_init().
The infinite variance code path in ReLUEst was broken as well, because
zhat0_mapandrelated variables did not get set in this code path.
Infinite variance handling was also added to LinEst and the unit tests for all four estimators have been extended to test the infinite variance cases.