Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for retinanet - annotation path mismatch #153

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Fixes for retinanet - annotation path mismatch #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de8399a
pass annotation dir instead of file
anandhu-eng Oct 17, 2024
2348845
removed assigning of unused env variable
anandhu-eng Oct 17, 2024
8232182
Changed the mount from annotation file to dir
anandhu-eng Oct 17, 2024
a08e402
Merge branch 'GATEOverflow:mlperf-inference' into sdxl_accuracy_fixes
anandhu-eng Oct 17, 2024
372c633
modified annotations env variable
anandhu-eng Oct 17, 2024
73f9435
Merge branch 'mlperf-inference' into sdxl_accuracy_fixes
anandhu-eng Oct 17, 2024
077b930
added annotation file papth to env key
anandhu-eng Oct 18, 2024
c9bbd2a
set validation annotation path env key
anandhu-eng Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/app-mlperf-inference-nvidia/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def preprocess(i):
dataset_path = env['CM_DATASET_OPENIMAGES_PATH']
#return {'return': 1, 'error': 'error'}

annotations_path = env['CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH']
annotations_path = env['CM_DATASET_OPENIMAGES_ANNOTATIONS_DIR_PATH']
target_data_path_dir = os.path.join(env['MLPERF_SCRATCH_PATH'], 'data', 'open-images-v6-mlperf')
if not os.path.exists(target_data_path_dir):
cmds.append(f"mkdir -p {target_data_path_dir}")
Expand Down
2 changes: 1 addition & 1 deletion script/app-mlperf-inference/_cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,7 +1658,7 @@ docker:
- "${{ CM_DATASET_IMAGENET_PATH }}:${{ CM_DATASET_IMAGENET_PATH }}"
- "${{ CM_DATASET_OPENIMAGES_PATH }}:${{ CM_DATASET_OPENIMAGES_PATH }}"
- "${{ CM_OPENIMAGES_CALIBRATION_DATASET_PATH }}:${{ CM_OPENIMAGES_CALIBRATION_DATASET_PATH }}"
- "${{ CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH }}:${{ CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH }}"
- "${{ CM_DATASET_OPENIMAGES_ANNOTATIONS_DIR_PATH }}:${{ CM_DATASET_OPENIMAGES_ANNOTATIONS_DIR_PATH }}"
- "${{ CM_MLPERF_INFERENCE_RESULTS_DIR }}:${{ CM_MLPERF_INFERENCE_RESULTS_DIR }}"
- "${{ OUTPUT_BASE_DIR }}:${{ OUTPUT_BASE_DIR }}"
- "${{ CM_MLPERF_INFERENCE_SUBMISSION_DIR }}:${{ CM_MLPERF_INFERENCE_SUBMISSION_DIR }}"
Expand Down
1 change: 1 addition & 0 deletions script/get-dataset-openimages/_cm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"CM_CALIBRATION_DATASET_PATH",
"CM_CALIBRATION_DATASET_PATH_ROOT",
"CM_OPENIMAGES_CALIBRATION_DATASET_PATH",
"CM_DATASET_OPENIMAGES_ANNOTATIONS_DIR_PATH",
"CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 077b930.

],
"tags": [
Expand Down
2 changes: 1 addition & 1 deletion script/get-dataset-openimages/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def postprocess(i):
env['CM_DATASET_PATH'] = os.path.join(os.getcwd(), 'install', 'validation', 'data')
annotations_file_path = os.path.join(env['CM_DATASET_ANNOTATIONS_DIR_PATH'], "openimages-mlperf.json")
env['CM_DATASET_VALIDATION_ANNOTATIONS_FILE_PATH'] = annotations_file_path
env['CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH'] = annotations_file_path
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful to have

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in c9bbd2a

env['CM_DATASET_ANNOTATIONS_FILE_PATH'] = annotations_file_path
env['CM_DATASET_OPENIMAGES_VALIDATION_ANNOTATIONS_FILE_PATH'] = annotations_file_path
if env.get("CM_DATASET_OPENIMAGES_CUSTOM_ANNOTATIONS",'') == "yes":
annotations_file_src = env['CM_DATASET_OPENIMAGES_ANNOTATIONS_FILE_PATH']
shutil.copy(annotations_file_src, env['CM_DATASET_ANNOTATIONS_DIR_PATH'])
Expand Down
Loading