Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added base image for amd r4.1 #154

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Added base image for amd r4.1 #154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3252b96
Added base image for amd r4.1
anandhu-eng Oct 21, 2024
8690324
added devices as extra run args
anandhu-eng Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions script/app-mlperf-inference/_cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,11 @@ variations:
cnndm-accuracy-script:
tags: _int32

amd,r4.1_default:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know the device parameter to be used while mounting the docker image? For nvidia, we use --gpus=all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arjunsuresh , they have cuda:0 on their run command here, so maybe the first gpu that is available?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD has used 3 devices while mounting the docker container: https://github.com/anandhu-eng/inference_results_v4.1/tree/ae60e11603a3e4f2253463a5c660f2db221bc5cb/closed/AMD/code/llama2-70b-99#amd-mlperf-inference-docker-container-setup

So, safe for us to do the same in CM.

docker:
base_image: rocm/pytorch:rocm6.1.2_ubuntu20.04_py3.9_pytorch_staging
extra_run_args: ' --device=/dev/kfd --device=/dev/dri --device=/dev/mem'

amd:
group:
implementation
Expand Down
Loading