forked from devicons/devicon
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade PR and Issue Templates (devicons#986)
* Update issue templates * Add pr templates * Update templates * Update pr templates * Update default pr template * Clarify pr closing statement * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
- Loading branch information
1 parent
bff3575
commit 02eeada
Showing
6 changed files
with
25 additions
and
82 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
## Double check these details before you open a PR | ||
|
||
<!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
- [ ] PR does not match another non-stale PR currently opened | ||
|
||
## Features | ||
<!-- List your features here and the benefits they bring. Include images/codes as appropriate --> | ||
|
||
**This PR closes NONE** | ||
<!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. --> | ||
|
||
## Notes | ||
<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,5 @@ | ||
# **New icon section** | ||
### Adding a New Icon? | ||
- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter` | ||
|
||
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New feature** section below. --> | ||
|
||
## Double check these details before you open a PR | ||
|
||
<!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
- [ ] PR does not match another non-stale PR currently opened | ||
- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview) | ||
- [ ] The PR's base is the `develop` branch. | ||
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines) | ||
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards) | ||
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-) | ||
|
||
<!-- Refer to the contributing guidelines for more details https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon --> | ||
|
||
## Link to prove your SVG is correct and up-to-date | ||
|
||
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. --> | ||
|
||
--- | ||
# **New feature section** | ||
|
||
<!-- If you are adding a new feature, follow the steps listed here, and delete the **New icon** section above. --> | ||
|
||
## Double check these details before you open a PR | ||
|
||
<!-- Tick the checkboxes to ensure you've done everything correctly --> | ||
- [ ] PR does not match another non-stale PR currently opened | ||
- [ ] PR name matches the format *New Feature: a brief description of feature* | ||
|
||
## This PR adds/fixes | ||
|
||
<!-- List your features here and the benefits they bring. --> | ||
|
||
## Notes | ||
|
||
<!-- List anything note-worthy here (potential issues, this needs to be merged to `develop` before working, etc.). --> | ||
### Adding a New Feature or fixing a bug? | ||
- Add `?quick_pull=1&template=new_feature.md` to the end of your current URL and press `Enter`. |