Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect diseases from close up images of tomatoes #128

Merged

Conversation

mirceatlx
Copy link
Collaborator

Detect diseases from close up images of tomatoes using transfer learning techniques.

Closes #109

@mirceatlx mirceatlx self-assigned this Mar 28, 2023
@mirceatlx mirceatlx requested a review from paulmis March 28, 2023 10:58
@mirceatlx mirceatlx linked an issue Mar 28, 2023 that may be closed by this pull request
4 tasks
@paulmis
Copy link
Collaborator

paulmis commented Mar 28, 2023

I'll review once you implemented the changes we discussed earlier today @mirceatlx

src/backend/pipeline/modules/preprocess.py Show resolved Hide resolved
src/backend/pipeline/modules/preprocess.py Show resolved Hide resolved
Comment on lines 25 to 29
if args.path is None or args.mode is None:
imgs = [Mat.read(file) for file in sorted(glob.glob("pipeline/test/data/mosaicing/farm/D*.JPG"))]
imgs = [Mat.read(file) for file in sorted(glob.glob("pipeline/test/data/disease/*.JPG"))]
path = "pipeline/test/data/mosaicing/farm/D*.JPG"
cloud_config = CloudConfig(bucket_name=output_bucket)
else:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this into a test? No need for extensive testing, but we're gonna overwrite main.py at some point and then it will be difficult to work with disease insights again.

Copy link
Collaborator

@paulmis paulmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirceatlx mirceatlx merged commit 5dd8b51 into dev Mar 30, 2023
@paulmis paulmis mentioned this pull request Apr 4, 2023
8 tasks
@paulmis paulmis deleted the 109-detect-pests-and-diseases-from-close-up-images-of-tomatoes branch April 4, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect pests and diseases from close-up images of tomatoes
2 participants