Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSON Server Support in the Growth Page | Issue #493 #537

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

Shariq2003
Copy link
Contributor

fix #493

This PR introduces support for fetching products and overviewProducts data from a JSON server, replacing the previous static import of products and overviewProducts data. The changes include:

  • Implemented JSON Server for products and overviewProducts:

    • Set up a local JSON server to provide dynamic products and overviewProducts data.
    • Updated the products and overviewProducts page to fetch products and overviewProducts data from the local server (http://localhost:5000/overviewProducts and http://localhost:5000/allProducts).
  • FAQs and Posts Page Updates:

    • Refactored the products and overviewProducts component to retrieve and display products and overviewProducts via the JSON server instead of a static products and overviewProducts import.

image
image
image

Related Issue:

Closes #493

How to Test:

  1. Ensure that the JSON server is running by executing the following command:
    npx json-server --watch db.json --port 5000

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. 😊

1 similar comment
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. 😊

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 We’re grateful for your pull request and the effort you put into it!
🔍 A maintainer will review it as soon as possible.
We’ll provide feedback if needed and merge it once approved.
Thanks for being an awesome part of our community! 💪

@Shariq2003
Copy link
Contributor Author

@rishicds sir, review

@rishicds rishicds merged commit 41831df into GDSC-RCCIIT:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement JSON Server for Temporary Data Loading on GDG
2 participants