Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human footprint pipeline clean #100

Open
wants to merge 79 commits into
base: main
Choose a base branch
from

Conversation

jupinator
Copy link
Contributor

this is the complete Human footprint pipeline

vicjulrin and others added 30 commits June 13, 2023 00:50
Co-Authored-By: Jean-Michel Lord <6223744+jmlord@users.noreply.github.com>
Cambio de nombre
Update of studyarea_to_wkt to be used in the workshop of July 31, 2023
Borrador en español de los textos yml del dpc
esto es una pry¿ueba
Changes are made in the description of the .yml arguments for the dPC indicator, some sections are translated and some disclaimers are included.
A part of the routine that was missing for the dPC indicator, is inserted
We have updated the auk_filter step script from the filter request (e.g. bbox- sp ) to the eBird zf table. The inputs and outputs were adjusted and tested in ByB with the documentation revised by Lina and Helena. The next step is to integrate the pipeline with the covars script step. However The inputs, ebd_file=ebd_CO_relDec-2022 and ebd_sampling_file=ebd_samp_Col_relDec-2022-002, should be manually loaded into the repository/00_auk_filter/input directory, as their size is too large to be accommodated in GIT. We could consider downsizing the dataset to a specific region in order to provide a functional pilot without going through that step.
change the way of presenting the final results
jupinator and others added 20 commits September 7, 2023 10:59
add the images of the documentation in Rmd for the protcon pipeline
-included author, name and external link in script of protcon pipe
-deleted .DS_Store
-deleted scripts/.DS_Store
-deleted README.html
-deleted protcon_test
-correct errors in .gpkg for  studyarea_to_WKT and spatial_to_DistanceMatrix
correct corrupt Colombian_protected_areas.gpkg file
delete redundant files for the Protcon calculation
All corrections and comment made by JM
reupload .gpkg corrupt file
+ re-saved pipeline to get latest changes in yml
@glaroc
Copy link
Contributor

glaroc commented Oct 4, 2023

Would it be possible to present the pipeline outputs as a time series graph as well as a table ? We would like to showcase it in the viewer (see and example with SHI here: https://biab2.geobon.org/viewer/SHI_pipeline%3E3652d5fd15ab1f7e4fbc5b648cddca30) and just showing a table would be quite boring...

@frousseu
Copy link
Contributor

frousseu commented Oct 4, 2023

Hi, if I'm choosing P1Y for the time interval, I'm getting this error in the log. Otherwise, it was running with the default values and P5Y.

There was an error in previous run: running again.
terra 1.7.46

Attaching package: ‘terra’

The following objects are masked from ‘package:magrittr’:

    extract, inset

Joining by: value
Joining by: value
Joining by: value
Joining by: value
Joining by: value
Joining by: Var1, Var2
Joining by: Var1, Var2
Joining by: Var1, Var2
Error in eval(ei, envir) : object 'dir_compare_data' not found
Calls: tryCatch -> tryCatchList -> tryCatchOne -> <Anonymous>
No traceback available 
          used (Mb) gc trigger  (Mb) max used  (Mb)
Ncells 1252474 66.9    2314894 123.7  2314894 123.7
Vcells 1842549 14.1    8388608  64.0  3608136  27.6
Error: output.json file not found
Elapsed: 5.214531872s

@frousseu
Copy link
Contributor

frousseu commented Oct 4, 2023

In the input form, it is not clear why an espg is required for the study area. Isn't it already supposed to be in the shp given for the study area? Or it is for transforming everything to this epsg?

Copy link
Contributor

@jmlord jmlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Protcon in there? It has it's own other pull request

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The casing makes it fail. Make sure to do a big find/replace of all to have the same casing. The folder has uppercase L, it should be lowercase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those images are for protcon analysis html file...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put these collections on an object storage online somewhere? Since it's a stac catalog, if you access it as stack it should work well... and it will avoid everyone downloading these tiffs. Its a lot of example tiffs since it is a time series...

description: Path to the output directory where the raster results of the metric analysis are saved
type: text
dir_info_layer:
label: info table path out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"info table" would be enought. When using mime types, it is always a path.

type: image/tiff;application=geotiff
dir_stack:
label: stack path out
description: Path to the output directory where the raster results of the metric analysis are saved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this output be an array of rasters instead?
That way we could show them in the viewer.

label: collection path
description: Path where the collection is hosted. The path can be hosted on the BIAB server (subject to approval from administrators) or in a cloud container
type: text
example: 'scripts/Load_collection/Collections/Colombia_human_footprint_collection'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accessed as a STAC catalog or a bunch of tiffs? If STAC then it could be put on some object storage and receive a path to the stac as an input.

label: time interval
description: String refering to the periods or intervals used for analysis. It specifies the length and units of time that will be considered for analyzing the data. For example, time intervals like 10Y (10 years), 5Y (5 years), 4M (4 months) can be used to define the time granularity for conducting the analysis. If no interval (time_interval) is specified, '1Y' is used by default
type: text
example: 'P10Y'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a P ? According to the description it should just be 10Y...

example: 'NA'
time_end:
label: End of time interval
description: "Refering to the ending date of the time interval. If this value is null or not provided, the minimum date from the column_date will be automatically taken as the starting date for the analysis. This argument is ignored if column_date=NULL."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence of the comment refers to the starting date. What happens for end date if column_date=NULL ?

- name: Maria Alejandra Molina Berbeo (mmolina@humboldt.org.co)
- name: Victor Julio Rincon (vrincon@humboldt.org.co)
- name: Luis Fernando Urbina (lurbina@humboldt.org.co)
external_link: https://github.com/GEO-BON/biab-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ot appropriate link. If there is no external link to put, please remove this.

dir_stack:
label: stack path in
description: Path to the input directory where the raster results of the metric analysis are saved
type: text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should receive an array of tiffs, not a directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in this PR, this is in Protcon pipeline.

author:
- name: Maria Alejandra Molina Berbeo (mmolina@humboldt.org.co)
- name: Victor Julio Rincon
external_link: https://github.com/GEO-BON/biab-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to a place where we can find the geopackages (and remove the gpkg from the repo)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep only one GPKG for example, put the rest on an object storage and link to it in the metadata.

the protcon pipe is eliminated leaving the HFI as the only pipe in the branch. Some scripts will be respited because are uses in the two pipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants