Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod] qa 반영 #195

Merged
merged 11 commits into from
Sep 25, 2023
Merged

[mod] qa 반영 #195

merged 11 commits into from
Sep 25, 2023

Conversation

jooyyoo
Copy link
Member

@jooyyoo jooyyoo commented Sep 23, 2023 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • 온보딩 뷰 텍스트 터치 영역 수정
  • 건빵 아이콘 사이즈 수정
  • 홈 뷰 - 홈 아이콘 선택 시 작아지는 이슈로 아이콘 변경
  • HACCP 마크 이미지 해상도 나눠서 넣기
  • 회원가입 뷰 수정
  • 리뷰 쓰기 - Divider 길이 확인 → 양 옆 떨어지게
  • 리뷰 쓰기 - ‘@@해 주세요’ → 띄어쓰기 변경
  • 닉네임 설정 뷰 페이지네이션 제거

Screenshot 📸

스크린샷 2023-09-24 오전 12 50 14

Uncompleted Tasks 😅

  • 온보딩 뷰 텍스트 터치 영역 수정
  • 건빵 아이콘 사이즈 수정 -> 수정 없음
  • 홈 뷰 - 홈 아이콘 선택 시 작아지는 이슈로 아이콘 변경
  • HACCP 마크 이미지 해상도 나눠서 넣기
  • 회원가입 뷰 수정 -> 수정 없음
  • 리뷰 쓰기 - Divider 길이 확인 → 양 옆 떨어지게
  • 리뷰 쓰기 - ‘@@해 주세요’ → 띄어쓰기 변경
  • 닉네임 설정 뷰 페이지네이션 제거

To Reviewers 📢

@jooyyoo jooyyoo added this to the 릴리즈 1차 QA 반영 milestone Sep 23, 2023
@jooyyoo jooyyoo self-assigned this Sep 23, 2023
@jooyyoo jooyyoo changed the title Mod 1st qa jooyoung [mod] qa 반영 Sep 23, 2023
jihyunniiii
jihyunniiii approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

언냐 고생했으 !!

@jooyyoo jooyyoo merged commit 7ffa1cd into develop Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyunniiii jihyunniiii jihyunniiii approved these changes

@Dan2dani Dan2dani Awaiting requested review from Dan2dani

Assignees

@jooyyoo jooyyoo

Labels
🔮mod 🔮 😽 주영 😽
Projects
GEON_PPANG_AOS
Status: Done
Milestone
릴리즈 QA 반영
Development

Successfully merging this pull request may close these issues.

[mod] QA 반영
2 participants
@jooyyoo @jihyunniiii