Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output run start/end/ranks #2426

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

klevzoff
Copy link
Contributor

@klevzoff klevzoff commented May 9, 2023

A tiny addition to standard GEOS output to make postprocessing of simulation logs easier.

@klevzoff klevzoff requested a review from TotoGaz May 9, 2023 08:47
@klevzoff klevzoff self-assigned this May 9, 2023
@klevzoff klevzoff force-pushed the feature/klevzoff/output-time-ranks branch from 7743e86 to 379233a Compare May 9, 2023 08:49
@klevzoff
Copy link
Contributor Author

klevzoff commented May 9, 2023

The two CI jobs with GCC 10 that are failing are being hit by this (or similar) compiler bug that is fixed for GCC 11: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95353

{fmt} version 9.1 contains some workarounds for similar issues, any objections to trying to update to that and seeing if it helps?

If that doesn't work, can I add -Wno-stringop-overflow to CI compiler flags for those jobs? I know this is heavy artillery, but we are still safeguarded by having this warning enabled in other builds.

@TotoGaz @rrsettgast

@klevzoff klevzoff force-pushed the feature/klevzoff/output-time-ranks branch from 379233a to be2918e Compare May 10, 2023 07:55
@klevzoff
Copy link
Contributor Author

The two CI jobs with GCC 10 that are failing are being hit by this (or similar) compiler bug that is fixed for GCC 11: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95353

{fmt} version 9.1 contains some workarounds for similar issues, any objections to trying to update to that and seeing if it helps?

If that doesn't work, can I add -Wno-stringop-overflow to CI compiler flags for those jobs? I know this is heavy artillery, but we are still safeguarded by having this warning enabled in other builds.

@TotoGaz @rrsettgast

This was not needed in the end, a simpler workaround was to add fmt includes as system includes on GEOS side to ignore warnings, as we do for some other TPLs. That said, I did test with fmt-9.1 and kept the necessary changes in this branch (they work with both old and new versions). I'm not gonna go through the trouble of updating TPLs at this time, but it should be very easy for someone else to do in the future.

@CusiniM CusiniM added ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed flag: ready for review labels May 10, 2023
@CusiniM CusiniM merged commit 8f27920 into develop May 10, 2023
@CusiniM CusiniM deleted the feature/klevzoff/output-time-ranks branch May 10, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants