Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for netCDF Quantize Support #289

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 9, 2022

This PR includes a change needed for supporting netCDF quantize testing in MAPL. This PR adds NETCDF_INCLUDE_DIRS as an alias to the INC_NETCDF that ESMA_cmake previously defined. As NETCDF_INCLUDE_DIRS is the more "standard" way to refer to this in CMake, this is also desirable for Spack capability.

Note that in GEOSgcm, only MAPL used INC_NETCDF so the rest of the model should be fine.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 9, 2022
@mathomp4 mathomp4 self-assigned this Nov 9, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner November 9, 2022 13:27
@mathomp4 mathomp4 merged commit 04f5e5a into develop Nov 9, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/1779-add-quantize-support branch November 9, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant