-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GNU_Fortran.make #292
Conversation
Adding compiler flags for x86_64 architecture and Linux
@natalie-perlin Could you move the new code until after the |
Modified as requested. Yes, absolutely, it may need to be the last option, if other conditions not satisfied.
In my test case, it could have been the configuration of Ubuntu running as a virtual machine on MacOS, which caused some mix-up of the expected outcomes/options.
|
Moved the code block for the x86_64 architecture flags past the "Intel" check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an entry in the ChangeLog.md file.
Ahh. Good call. I've changed the label to be 0-diff as the "trivial" label skips the changelog. But this is a pretty substantive change! |
@natalie-perlin Can you make an update to the |
@mathomp4 - Updated the Changelog. Please let me know if any modification are needed for the log. |
Doing a final check now to make sure this is good when on native Intel (as it should be). |
Adding compiler flags for x86_64 architecture and Linux.
Tested for building MAPL/2.22.0 using ESMA_cmake/3.12.0 on Ubuntu22.04 Linux machine with x86_64 architecture.
This PR solves issue Issue#291