Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GNU_Fortran.make #292

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Conversation

natalie-perlin
Copy link
Contributor

Adding compiler flags for x86_64 architecture and Linux.

Tested for building MAPL/2.22.0 using ESMA_cmake/3.12.0 on Ubuntu22.04 Linux machine with x86_64 architecture.

This PR solves issue Issue#291

Adding compiler flags for x86_64 architecture and Linux
@natalie-perlin natalie-perlin requested a review from a team as a code owner November 17, 2022 03:40
@mathomp4
Copy link
Member

@natalie-perlin Could you move the new code until after the Intel section? I'd prefer something like this to be the last possible choice in an if-test.

@natalie-perlin
Copy link
Contributor Author

natalie-perlin commented Nov 17, 2022 via email

Moved the code block for the x86_64 architecture flags past the "Intel" check.
@tclune tclune added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Nov 17, 2022
@tclune tclune self-requested a review November 17, 2022 16:29
tclune
tclune previously requested changes Nov 17, 2022
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an entry in the ChangeLog.md file.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Nov 17, 2022
@mathomp4
Copy link
Member

Needs an entry in the ChangeLog.md file.

Ahh. Good call. I've changed the label to be 0-diff as the "trivial" label skips the changelog. But this is a pretty substantive change!

@mathomp4
Copy link
Member

@natalie-perlin Can you make an update to the CHANGELOG.md detailing this PR. That way it can pass our tests.

@natalie-perlin
Copy link
Contributor Author

@mathomp4 - Updated the Changelog. Please let me know if any modification are needed for the log.

@mathomp4
Copy link
Member

Doing a final check now to make sure this is good when on native Intel (as it should be).

@mathomp4 mathomp4 merged commit 6d2c66f into GEOS-ESM:develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants