Turn off ESMF_HAS_ACHAR_BUG for NAG #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
tclune
previously approved these changes
Jan 9, 2024
|
Thank you, @mathomp4! That works for me on Mac with NAG compiler for the develop branch and my local branch. |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests by @metdyn and myself seem to indicate the
ESMF_HAS_ACHAR_BUGCMake option is no longer needed for NAG. Indeed, turning it on seems to break ExtData tests (at least).Will consult with @tclune (and maybe ESMF) before committing and releasing.