Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17 - remove "@" in debug var names. #36

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Fixes #17 - remove "@" in debug var names. #36

merged 1 commit into from
Oct 1, 2019

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Sep 27, 2019

No description provided.

@tclune tclune requested a review from mathomp4 September 27, 2019 13:57
@tclune
Copy link
Collaborator Author

tclune commented Oct 1, 2019

Probably should write a macro that strips the "@" directly, as this logic is now in at least 2 places in our code.

mathomp4
mathomp4 approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, things built without it, though I still want a tutorial from you on how to use this.

Though, now that I think about it, maybe it didn't work for me the one time I tried because of the @?

@mathomp4 mathomp4 merged commit b512a04 into develop Oct 1, 2019
@mathomp4 mathomp4 deleted the feature/tclune/#17-remove-at-in-debug-vars branch December 5, 2019 13:50
mathomp4 added a commit that referenced this pull request Apr 13, 2020
@mathomp4
Merge branch 'develop' into feature/mathomp4/#36-add-optics-cmake
0b801ba
mathomp4 added a commit that referenced this pull request Apr 15, 2020
@mathomp4
Merge pull request #77 from GEOS-ESM/feature/mathomp4/#36-add-optics-…
4ee2187 
…cmake

Update to allow MAM Optics f2py to build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @mathomp4