Fixes for f2py and imagemagick #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes some issues where systems do not have either ImageMagick or F2Py. If F2Py is not found, then F2Py targets are not built.
This seems to do better. The main issues were because we need to test the exact f2py that the system finds. This now compiles a test subroutine with f2py and looks for a output .so or .alksdjfasd.so
This was referenced Mar 25, 2020
|
Adding @sdrabenh as a reviewer mainly to keep him aware of the multi-repo-ness of this change. |
bena-nasa
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for systems where f2py and ImageMagick might not be installed or set up correctly. This is useful for things like AWS or laptops as neither of these two features are needed if you are trying to run just
GEOSgcm.x.Obviously, on operational systems we need both.
This should be taken in concert with:
#62
GEOS-ESM/GEOSchem_GridComp#68
GEOS-ESM/GMAO_Shared#84
GEOS-ESM/UMD_Etc#11
That said, if the ESMA_cmake PR/change is not taken, the model will still build, but no f2py will run (as it's missing the
F2PY_FOUNDvariable).