Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates needed to run on SLES15 at NCCS #49

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Updates needed to run on SLES15 at NCCS #49

merged 3 commits into from
Aug 22, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 19, 2024 •
edited
Loading

This PR has updates needed for building and running on SLES15 at NCCS

This PR will depend on tags in ESMA_env and ESMA_cmake:

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 19, 2024
@mathomp4 mathomp4 self-assigned this Aug 19, 2024
@mathomp4 mathomp4 added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Aug 19, 2024
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

3 similar comments
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@mathomp4 mathomp4 removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Aug 19, 2024
@mathomp4 mathomp4 marked this pull request as ready for review August 19, 2024 19:52
@mathomp4 mathomp4 requested review from a team as code owners August 19, 2024 19:52
@mmanyin
Copy link
Contributor

mmanyin commented Aug 20, 2024

@mathomp4 is correct that this PR is zero-diff, when running SLES12. However it is non-zero diff when running SLES15, on the order of roundoff. We have seen this disparity in GCM too, no surprise. I'm adding the non-zero-diff tag for completeness.

@mmanyin mmanyin added the Non 0-diff The changes in this pull request are non-zero-diff label Aug 20, 2024
mmanyin
mmanyin approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now runs SLES15 as well as SLES12 - excellent work.

@mathomp4 mathomp4 merged commit 5450084 into main Aug 22, 2024
6 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/sles15 branch August 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanyin mmanyin mmanyin approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @mmanyin