Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to mom geos/v1.0.2 and MAPL 2.1.5 #153

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 5, 2020

This is a sister PR to GEOS-ESM/GEOSgcm_GridComp#293 which updates the components.yaml for mom (at least) to geos/v1.0.2

Also updates the components.yaml and cfg files to MAPL 2.1.5

@mathomp4 mathomp4 requested a review from a team as a code owner June 5, 2020 18:28
@mathomp4 mathomp4 added the Contingent - DNA These changes are contingent on other PRs label Jun 5, 2020
@yvikhlya
Copy link

@matt This PR can be safely approved before GEOS-ESM/GEOSgcm_GridComp#293 is approved.

@mathomp4
Copy link
Member Author

@matt This PR can be safely approved before GEOS-ESM/GEOSgcm_GridComp#293 is approved.

@yvikhlya It can? There is no "missing interface" or anything?

@yvikhlya
Copy link

@matt This PR can be safely approved before GEOS-ESM/GEOSgcm_GridComp#293 is approved.

@yvikhlya It can? There is no "missing interface" or anything?

@mathomp4 It is just additional function. Atanas also fixed MAPL dependency (GEOS-ESM/MAPL#414), I tested it and it works. MAPL also need to be tagged and components.yaml updated accordingly. Once it is done, my PR (GEOS-ESM/GEOSgcm_GridComp#293) can be approved.

@mathomp4
Copy link
Member Author

@matt This PR can be safely approved before GEOS-ESM/GEOSgcm_GridComp#293 is approved.

@yvikhlya It can? There is no "missing interface" or anything?

@mathomp4 It is just additional function. Atanas also fixed MAPL dependency (GEOS-ESM/MAPL#414), I tested it and it works. MAPL also need to be tagged and components.yaml updated accordingly. Once it is done, my PR (GEOS-ESM/GEOSgcm_GridComp#293) can be approved.

Well, it should be approved at the same time as GEOS-ESM/GEOSgcm_GridComp#293 so there isn't inconsistency at least configurations. But for now, at least, I'll remove the DNA.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed Contingent - DNA These changes are contingent on other PRs labels Jun 10, 2020
@mathomp4
Copy link
Member Author

Updated all to MAPL 2.1.5

@mathomp4 mathomp4 changed the title Move to mom geos/v1.0.2 Move to mom geos/v1.0.2 and MAPL 2.1.5 Jun 11, 2020
@yvikhlya
Copy link

yvikhlya commented Jun 11, 2020

@mathomp4 Can it go now together with GEOS-ESM/GEOSgcm_GridComp#293?

@mathomp4
Copy link
Member Author

@mathomp4 Can it go now together with GEOS-ESM/GEOSgcm_GridComp#293?

Yes. If @sdrabenh takes GEOS-ESM/GEOSgcm_GridComp#293, this one should go with it (and would have to, I think, since MAPL update is needed).

tclune pushed a commit that referenced this pull request Jun 12, 2020
@sdrabenh sdrabenh merged commit 9641b76 into master Jun 12, 2020
@sdrabenh sdrabenh deleted the feature/yury/s2s3-merge branch June 12, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants