WMMA #872
Merged
WMMA #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WGCM is a sibling of AGCM and OGCM. The WGCM component can be run in either one-way coupled (passive) mode or two-way coupled mode. The selection of a wave model is done through the WGCM.rc file.
Extend DataSea GC to export ocean depth and currents. These fields are just pass-through and are meant to be provided by the ExtData GC.
Modify dry static energy and water vapor when the sea spray parameterization is active.
Two way AGCM-WGCM coupling through air-sea momentum exchange based on dynamical Charnock parameter and sea spray mediated heat fluxes.
When the active wave model is WW3, both the WW3 adapter/plug component and the WGCM component need to be on the WW3 grid, otherwise the regridded WW3 forcings and thus the modeled waves will be incorrect.
…f the ww3 mapl plug
…face and resolve conflicts in: GEOS_GcmGridComp.F90 GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90 GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_OpenWaterGridComp.F90 GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_SaltWaterGridComp.F90 GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSturbulence_GridComp/GEOS_TurbulenceGridComp.F90 GEOSogcm_GridComp/GEOS_OgcmGridComp.F90
- Abandon the 2D decomposition approach in favour of the 1D decomposition in UMWM. This allows for easier use of the standalone UMWM code in the GEOS implementation and thus easier integration and maintenance. - A notable limitation of the built in 1D decomposition is the assumption that halo is constructed and updated with points belonging/assigned to *only one* process. E.g. on MPI rank N, all west boundary grid cells must have west neighbors that belong on MPI rank N-1 and no other, and all east boundary grid cells must have east neighbors that belong on MPI rank N+1 and no other. This assumption requires that the number of processes cannot exceed a certain value that depends on the number of water points.
Enable the calculation of the dynamical Charnock parameter. There are no changes in the formulation.
adarmenov
dismissed stale reviews from lcandre2, gmao-rreichle, and tclune
via
03ab2d6
|
I'm taking a look at this now to fix the GNU build issue and I might have some CMake changes to suggest. I'll let you know. |
|
@adarmenov Oh. I might have made my PR to the wrong branch? This PR: Is going against Would you like me to make a PR against this branch? |
|
@mathomp4 I keep the two branches synced with each other. You do not have to make a new PR. |
sanAkel
reviewed
Jan 11, 2024
sanAkel
reviewed
Jan 11, 2024
sanAkel
reviewed
Jan 11, 2024
.../GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_OpenWaterGridComp.F90
Show resolved
Hide resolved
sanAkel
reviewed
Jan 11, 2024
sdrabenh
removed
the
Contingent - DNA
sdrabenh
approved these changes
Jan 30, 2024
mathomp4
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate WMMA changes into develop.