Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add features from Hunga work #24

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Dec 6, 2024

Captured all edits done for the 2024 Hunga experiments; this includes adding SO4v, using sulfate SAD and EffRadius from the AERO state, and a new SAD LBS option (5). This PR is zero-diff when none of the new features are used.

@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 6, 2024
@mmanyin mmanyin requested a review from a team as a code owner December 6, 2024 23:14
Copy link
Contributor

@ssteenro ssteenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoroughly vetted I bet

@mmanyin
Copy link
Contributor Author

mmanyin commented Dec 18, 2024

One clarification - H2SO4 is different in the 'restart' files, but this is because it is now set to 1e-30 at the beginning of each Run routine, instead of at the end. All other chemical species are zero-diff.

@mmanyin mmanyin merged commit 9c2c787 into develop Dec 27, 2024
11 checks passed
@mmanyin mmanyin deleted the feature/mmanyin/edits_from_hunga_work branch December 27, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants