Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for QQJK diag bug #9

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

ssteenro
Copy link
Contributor

qqjk calculation used t+dt constituent fields instead of at time t - fix

@ssteenro ssteenro added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 19, 2023
@ssteenro ssteenro requested a review from a team as a code owner July 19, 2023 15:15
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a good fix for the QQJ and QQK diagnostics. All else is zero-diff.

@mmanyin
Copy link
Contributor

mmanyin commented Jul 19, 2023

@mathomp4 - This PR is failing the build-test because GMI currently requires CHEM release v1.13.1 or later. I've verified that things are working properly, with the updated CHEM. Can you please over-ride the build-tests ? thanks

@mathomp4
Copy link
Member

@mmanyin Build tests are now not required. It should be mergable

@mmanyin mmanyin merged commit 34df261 into develop Jul 19, 2023
@mmanyin mmanyin deleted the feature/ssteenro/fix_QQJK_diag_bug branch July 19, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants