Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes # 1656 #1658

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fixes # 1656 #1658

merged 2 commits into from
Sep 7, 2022

Conversation

bena-nasa
Copy link
Collaborator

Fixes #1656

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring labels Sep 6, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner September 6, 2022 20:57
mathomp4
mathomp4 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to remove dead code. Approve

@mathomp4 mathomp4 linked an issue Sep 7, 2022 that may be closed by this pull request
Unused keywords should be removed from History source code #1656
Closed
@bena-nasa bena-nasa merged commit a4ee7a7 into develop Sep 7, 2022
@bena-nasa bena-nasa deleted the feature/bmauer/fixes-#1656 branch September 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused keywords should be removed from History source code
2 participants
@bena-nasa @mathomp4