Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary DSO lib name assertion #1664

Merged
merged 2 commits into from
Sep 12, 2022
Merged

remove unnecessary DSO lib name assertion #1664

merged 2 commits into from
Sep 12, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Sep 8, 2022 •
edited by mathomp4
Loading

Removed unnecessary ASSERT. If a wrong extension name of DSO lib is given, the assertion stops the program. it defeats the purpose of adjusting the extension a few lines below. It addresses issue #1663

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Sep 8, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 8, 2022 15:34
@mathomp4 mathomp4 added bugfix and removed 🪲 Bugfix This fixes a bug! labels Sep 12, 2022
@mathomp4
Copy link
Member

Hmm. Something went wonky at CircleCI. I'll re-run the tests.

@mathomp4
Copy link
Member

I just tested this with GEOSgcm at c24 and with MOM6 C12. Seems to work

@mathomp4 mathomp4 linked an issue Sep 12, 2022 that may be closed by this pull request
No need to ASSERT here #1663
Closed
@mathomp4 mathomp4 merged commit 04fac26 into develop Sep 12, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/remove_dso_extension_assert branch September 12, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No need to ASSERT here
2 participants
@weiyuan-jiang @mathomp4