Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1668. Only allow certain History modes #1669

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Sep 9, 2022

Description

This change makes it so that only instantaneous and time-averaged are allowed as a mode in History collections.

Related Issue

Closes #1668

Motivation and Context

Makes history more precise and protects against possible confusion.

How Has This Been Tested?

Tested with GEOS. If there are no errors, zero-diff. But with errors you get:

pe=00044 FAIL at line=01778    MAPL_HistoryGridComp.F90                 <Invalid mode [time-average] for collection [geosgcm_surf]. Only 'instantaneous' and 'time-averaged' are supported>

or:

pe=00043 FAIL at line=01778    MAPL_HistoryGridComp.F90                 <Invalid mode [instantanious] for collection [geosgcm_prog]. Only 'instantaneous' and 'time-averaged' are supported>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 9, 2022
@mathomp4 mathomp4 self-assigned this Sep 9, 2022
@mathomp4 mathomp4 marked this pull request as ready for review September 9, 2022 18:52
@mathomp4 mathomp4 requested a review from a team as a code owner September 9, 2022 18:52
@mathomp4 mathomp4 merged commit ebcffd9 into develop Sep 12, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/1668-history-mode-protect branch September 12, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants