Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1991
The problem was that I was defining the file reference date relative to the application start time of the clock, this is fine for non-climatological handling of data.
But for climatological handling (where you must provide the valid_range) it is not.
I was being sloppy and using the year from the valid range to set the reference date, but I really needed to examine full time for the start of the valid_range and correlate that to the file_template to determine the appropriate file reference time
This was only apparent when the application ran for extended times when you crossed a year and it had to update the brackets within a single execution.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: