Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1991 #2001

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fixes #1991 #2001

merged 2 commits into from
Mar 6, 2023

Conversation

bena-nasa
Copy link
Collaborator

This fixes issue #1991
The problem was that I was defining the file reference date relative to the application start time of the clock, this is fine for non-climatological handling of data.
But for climatological handling (where you must provide the valid_range) it is not.

I was being sloppy and using the year from the valid range to set the reference date, but I really needed to examine full time for the start of the valid_range and correlate that to the file_template to determine the appropriate file reference time

This was only apparent when the application ran for extended times when you crossed a year and it had to update the brackets within a single execution.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Mar 3, 2023
@bena-nasa bena-nasa requested a review from a team as a code owner March 3, 2023 16:28
@mathomp4 mathomp4 requested a review from a team as a code owner March 3, 2023 16:35
@mathomp4
Copy link
Member

mathomp4 commented Mar 3, 2023

@bena-nasa I borrowed this PR to get it ready for a release once merged.

Also, did you do a run of "normal" GEOS to make sure that is all zero-diff?

@mathomp4 mathomp4 merged commit f5237a3 into main Mar 6, 2023
@mathomp4 mathomp4 deleted the hotfix/bmauer/fixes-#1991 branch March 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants