Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the call ioserver_profiler%stop to the right place #2109

Merged
merged 1 commit into from
Apr 28, 2023
Merged

move the call ioserver_profiler%stop to the right place #2109

merged 1 commit into from
Apr 28, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Apr 28, 2023 •
edited
Loading

The program crashed at the end when reporting ioserver_profiler in debug mode. It turns out the stop method is not in the right place when io server is on the same processes as the model.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Apr 28, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner April 28, 2023 16:58
@mathomp4 mathomp4 merged commit 161d94a into develop Apr 28, 2023
@mathomp4 mathomp4 deleted the bugfix/wjiang/ioserver_profiler_stop branch April 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan-jiang @mathomp4