Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2274 #2277

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fixes #2274 #2277

merged 2 commits into from
Aug 1, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Aug 1, 2023

Workaround for issue with NAG and ESMF_Config SetAttribute()

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of MAPL unit tests that exercise the feature
  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune
Fixes #2274
20547ea 
Workaround for issue with NAG and `ESMF_Config` SetAttribute()
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Aug 1, 2023
@tclune tclune requested a review from a team as a code owner August 1, 2023 13:25
bena-nasa
bena-nasa previously approved these changes Aug 1, 2023
View reviewed changes
atrayano
atrayano previously approved these changes Aug 1, 2023
View reviewed changes
@tclune tclune dismissed stale reviews from atrayano and bena-nasa via 085647e August 1, 2023 13:55
@mathomp4 mathomp4 self-requested a review August 1, 2023 14:51
mathomp4
mathomp4 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model seems happy. Approved.

@mathomp4 mathomp4 merged commit 3a9510a into main Aug 1, 2023
@mathomp4 mathomp4 deleted the hotfix/tclune/#2274-setattribute-workaround branch August 1, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@bena-nasa bena-nasa bena-nasa left review comments

@atrayano atrayano atrayano left review comments

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tclune @mathomp4 @bena-nasa @atrayano