Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plain_netCDF_Time to use standard MAPL error handling #2386

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

darianboggs
Copy link
Contributor

Description

Make Plain_netCDF_Time (base/Plain_netCDF_Time.F90) consistent with standard MAPL error handling.

Related Issue

#2375

Motivation and Context

Using standard MAPL error handling allows better location of problems through stack traces.

How Has This Been Tested?

Ran successful 0-diff GEOSgcm runs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@darianboggs darianboggs added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 27, 2023
@darianboggs darianboggs requested a review from a team as a code owner September 27, 2023 04:39
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually I want to give some thought if this can/should be merged with Netcdf4_FileFormatter.

@darianboggs darianboggs self-assigned this Sep 27, 2023
@darianboggs
Copy link
Contributor Author

Eventually I want to give some thought if this can/should be merged with Netcdf4_FileFormatter.

I agree. The NetCDF handling should be consolidated in MAPL. There is redundancy, probably. The handling of CF units itself could be a module itself.

@darianboggs darianboggs merged commit c76012c into develop Sep 27, 2023
@mathomp4 mathomp4 deleted the feature/wdboggs/modify_check_nc_status branch September 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants