Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GEOSadas CI Build #2409

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Update GEOSadas CI Build #2409

merged 2 commits into from
Oct 16, 2023

Conversation

mathomp4
Copy link
Member

Description

This PR moves the GEOSadas CI build to use a branch that more closely tracks the current GEOSgcm main. GEOSadas has fallen too behind and so things will fail as repos are missing, etc.

Related Issue

Motivation and Context

Gives the CI GEOSadas branch a chance at compiling.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Oct 16, 2023
@mathomp4 mathomp4 self-assigned this Oct 16, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner October 16, 2023 13:26
tclune
tclune previously approved these changes Oct 16, 2023
View reviewed changes
@mathomp4 mathomp4 requested a review from a team October 16, 2023 16:14
@tclune tclune merged commit 4b07b10 into develop Oct 16, 2023
@tclune tclune deleted the bugfix/mathomp4/fix-adas-ci branch October 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune