Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action unit test and process test versions updated #208

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

PennyHow
Copy link
Member

@PennyHow PennyHow commented Nov 2, 2023

This was raised by @BaptisteVandecrux in his latest PR #207 where the unit test was not working due to the pkg_resources package not being recognised.

I discovered the problem was with the Github Action itself - we are using an old version of the checkout and setup-python Actions, which have just been deprecated. So I have updated these in this PR.

In addition, to make sure we don't have problems from this again, I have hard coded for the setuptools package to be upgraded during the Python setup step in each Action. This should mean that the pkg_resources package will be found for running the unit test and process test.

After this PR is merged with the main branch, then you should be able to run the Actions on your PR @BaptisteVandecrux. Then you should be able to continue with merging.

@BaptisteVandecrux
Copy link
Member

Thanks Penny!

My only comment is that you use checkout@v3 when they have released a checkout@v4: https://github.com/actions/checkout
I guess it doesn't matter right now but it is annoying that they deprecate things that fast.
checkout@v2's last release was May 30 this year!

@PennyHow
Copy link
Member Author

PennyHow commented Nov 2, 2023

My only comment is that you use checkout@v3 when they have released a checkout@v4: https://github.com/actions/checkout I guess it doesn't matter right now but it is annoying that they deprecate things that fast. checkout@v2's last release was May 30 this year!

I thought about this, but chose checkout@v3 because all examples use the specific combination of checkout@v3 and setup-python@v4. I think we can update it in the future when they begin pushing for v4 in their examples though.

@PennyHow PennyHow merged commit 7261c27 into main Nov 2, 2023
10 checks passed
@PennyHow PennyHow deleted the action-version-update branch November 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants