Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): add publishing options #5

Merged
merged 4 commits into from
Nov 15, 2024
Merged

feat(publish): add publishing options #5

merged 4 commits into from
Nov 15, 2024

Conversation

Gijsdeman
Copy link
Contributor

@Gijsdeman Gijsdeman commented Nov 14, 2024

Splits the publishing config in different files.

To test before merging:

  • Versioning publish workflow
  • NPM publish workflow
  • Docker publish workflow

To add before mering:

  • Update the README
  • Adding some examples
  • Consider adding a yarn install --development or npm ci to the NPM publish

For the last step; I intentionally did not do this as this once again would have led to a difference between yarn and npm. However, I feel like this should be a step part of the "built-and-lint" flow instead, where you write a test that checks if all your packages can be installed without issues. How this would look like under the hood I am unsure, but that is a problem for later.

@Gijsdeman Gijsdeman force-pushed the Feat/lerna branch 2 times, most recently from a5b500e to 7025dc7 Compare November 15, 2024 21:20
@Gijsdeman Gijsdeman force-pushed the Feat/lerna branch 2 times, most recently from 0cc8130 to 1f92ef2 Compare November 15, 2024 21:44
@Gijsdeman Gijsdeman force-pushed the Feat/lerna branch 2 times, most recently from b527d05 to b63d79a Compare November 15, 2024 21:45
@Gijsdeman
Copy link
Contributor Author

Closes #4.

@JustSamuel JustSamuel force-pushed the Feat/lerna branch 2 times, most recently from 02c35c7 to b393040 Compare November 15, 2024 22:04
@Gijsdeman Gijsdeman merged commit 7e7f8bd into main Nov 15, 2024
1 check passed
@Gijsdeman Gijsdeman deleted the Feat/lerna branch November 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants