feature(poster): Add Hubble poster handler #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoronex
approved these changes
Dec 18, 2024
src/modules/handlers/screen/poster/gewis/gewis-poster-screen-controller.ts
Outdated
Show resolved
Hide resolved
src/modules/handlers/screen/poster/base-poster-screen-handler.ts
Outdated
Show resolved
Hide resolved
src/modules/handlers/screen/poster/base-poster-screen-controller.ts
Outdated
Show resolved
Hide resolved
|
Oh and please also verify the interoperability with the Backoffice, because stuff might break because the endpoints have changed. Maybe you even want a single endpoint to return the posters and force refresh them? Because then you can keep just a single poster overview in the backoffice. Stuff like colors and BorrelMode can be made (in)visible with conditional rendering using feature flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Hubble poster handler to the core
Description
Abstract most base behavior to base classes and extend for GEWIS and Hubble with the needed features.
Also adds colors as option in the posters, and hides everything behind feature flags
Related issues/external references
Types of changes