Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve approve organ page #1383

Open
LeonVreling opened this issue Mar 14, 2022 · 4 comments · May be fixed by #1903
Open

Improve approve organ page #1383

LeonVreling opened this issue Mar 14, 2022 · 4 comments · May be fixed by #1903
Assignees
Labels
Module: Decision For anything related to the Decision module Priority: Low Type: Enhancement

Comments

@LeonVreling
Copy link
Member

Currently, the board needs to approve changes an organ makes to their page on the GEWIS website. This process is, however, not that nice in my personal experience.

One thing that could be improved is a preview of the image that you are approving, cause now you can only view the text. We could maybe make a new page that shows the old version on the left side, and the new proposed changes on the right side. This also makes the checking of the text easier.

Let me know what you think about this 😄

@tomudding
Copy link
Member

I have always wanted to properly implement a Git-like diff system (which would also be used in the Activity module), however, I have not found a package that can do this for natural text (and I most certainly do not have the time to implement something like that myself).

If we get something working, we can also use it in the upcoming update to the company module, as that also heavily relies on diffs.

@tomudding tomudding added Type: Enhancement Priority: Low Module: Decision For anything related to the Decision module labels Mar 14, 2022
@tomudding
Copy link
Member

tomudding commented Mar 14, 2022

Perhaps lolli42/finediff can do the diff thing, however, images might be a bit more difficult.

@tomudding
Copy link
Member

jfcherng/php-diff is probably the best package we can get if we want to do this in PHP. We can potentially also move this to something JavaScript based (if performance becomes an issue).

@tomudding
Copy link
Member

image

Side by side for larger HTML-based textual diffs. Inline for simple text diffs. Unified/combined for single line diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Decision For anything related to the Decision module Priority: Low Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants