Improve reviewing of update proposals by using proper diffs #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `php-diff` to generate different styles of diffs for different kinds of texts:" - Combined: single-line text - Inline: longer multi-line text (e.g., descriptions) - SideBySide: long complex text (e.g., HTML pages) Does require a small patch to ensure that we always generate a diff, even when the inputs are equal.
|
The constant most certainly exists. |
github-actions bot
added a commit
that referenced
this pull request
Jul 9, 2023
Tom Udding: Merge pull request #1669 from tomudding/feature/improved-update-proposal-diffs Improve reviewing of update proposals by using proper diffs Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
php-diffto generate different styles of diffs for different kinds of texts:"Does require a small patch to ensure that we always generate a diff, even when the inputs are equal (see GEWIS/gewisweb-php-diff).
This forms the basis for GH-1383 (which requires some extensive changes).