Add automatic birthday balloons #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the past few years I have manually added the balloons to the website on the 28th of June, however, it is better to just have this implemented so I do not have to do this anymore. For GEWIS' 40th birthday it was decided that 40 balloons was optimal for both small and large screens. This should not be changed without careful consideration as it may negatively affect the usability of the website. --- Removal of entry in `.gitignore` came from GEWISGH-1790 to ensure that the SCSS files are tracked.
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2024
Tom Udding: Merge pull request #1849 from tomudding/feature/automatic-birthday-balloons Add automatic birthday balloons Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the past few years I have manually added the balloons to the website on the 28th of June, however, it is better to just have this implemented so I do not have to do this anymore.
For GEWIS' 40th birthday it was decided that 40 balloons was optimal for both small and large screens. This should not be changed without careful consideration as it may negatively affect the usability of the website.
Removal of entry in
.gitignorecame from GH-1790 to ensure that the SCSS files are tracked.Types of changes