refactor(dashboard/banner-forms): refactored the banner forms to use new ones #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dates in the past are not properly handled, as this throws a 400 on the backend Forms are not cleared when closing the dialog, so the image from one can be transferred to another if the other has no banner defined. As well as when clicking on create again Would be nice if the InputNumber is suffixed with s to indicate the number is seconds not milliseconds I am not sure if I agree with the placeholder name being "BAC Weekend" maybe just "Please insert banner name" Form validation when not providing an end date does not work |
…it forms into using new forms
…banner in edit banner dialog
JustSamuel
force-pushed
the
refactor/banner-forms-picked
branch
from
b0d65cf to
eb870c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure to use the new forms in the banner components.
Related issues/external references
One of many #273
Types of changes