Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data extraction: handling of tags that have same key as a property (e.g. @osmId) #40

Closed
FabiKo117 opened this issue Aug 28, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FabiKo117
Copy link
Contributor

As raised in a discussion in another issue, how should we deal with tags that also start with the "@" sign?

Escaping them through adding a 2nd @ could be a good way to go. This would only be necessary though on tags that have the same name as one of our property, e.g. the @osmId tag and not on all tags starting with @.

@FabiKo117 FabiKo117 added the enhancement New feature or request label Aug 28, 2020
@joker234
Copy link
Member

Thanks for excluding that from the other issue.

I would suggest to change all keys matching ^@ to @@, document that, and for the very rare cases someone wants to use that tags, we don't have a problem there.

@FabiKo117
Copy link
Contributor Author

Yeah we could also do it like that. As you say it would then just be important to document it properly, because if the user would request then for @ the response actually has @@ at the start of the tag.

@FabiKo117 FabiKo117 added this to the 1.3 milestone Nov 10, 2020
tyrasd pushed a commit that referenced this issue Jan 7, 2021
manually squash of the following commits:
* 3c4c5b6
* a240374
* 42cc9fb
* 8b20332
* ff09be4
* ec431a3
* 7bc17e6
* d431854
* 7cba1d7
* 518151b

fixes #40
tyrasd pushed a commit that referenced this issue Jan 7, 2021
manually squash of the following commits:
* 3c4c5b6
* a240374
* 42cc9fb
* 8b20332
* ff09be4
* ec431a3
* 7bc17e6
* d431854
* 7cba1d7
* 518151b

fixes #40
@tyrasd tyrasd closed this as completed in 4a7e393 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants