-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid unneccessary geometry building during count/ratio requests #161
Conversation
src/main/lombok/org/heigit/ohsome/ohsomeapi/executor/ElementsRequestExecutor.java
Show resolved
Hide resolved
a131d58
to
75057f3
Compare
e7ba4b8
to
cf3bcfc
Compare
benchmark query:
|
eb2b6c7
to
eaca19a
Compare
eaca19a
to
3d0d93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good 👍 Just some minor remarks/questions.
Description
Improve performance of
count
queries by skipping callinggetGeometry
in thecount
code paths. This eliminates the (sometimes expensive) construction of JTS geometries in cases where it is not actually needed.Todo
Checklist
I have written javadoc (required for public methods)I have made corresponding changes to the documentationI have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.