-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swagger tweaks: reordering and remove deprecated parameters #168
Conversation
I agree with both points: bringing a specific ordering in the speccs and further removing the deprecated What just came into my mind: Would it make sense to include a specific message (e.g. in a dedicated JSON field) in the response if the user used a deprecated parameter, endpoint, whatever to get this response and that he/she should check the docs and update this, as this specific request won't work anymore after the next major release? To better display this, we could add a specific section in the docs explaining which parameters, endpoints, etc. were deprecated in which version and from when they won't be available anymore. |
That sounds like a good idea! 👍 At least for the JSON (aggregation) output format this should be possible without a problem. I'm not 100% sure about csv (maybe including it in the header comment would work?) and GeoJSON, though. |
by not displaying it in swagger anymore
Description
A few changes to the swagger api playground:
count
first, thenlength
,area
andperimeter
, thenusers
and lastcontributions
geometry
, thenelementsFullHistory/geometry
, thencontributions/geometry
contributions
endpoints), yet swagger still shows them as apparently valid options.make time parameter for contribution endpoint optional (fall back to full time range if not specified??) TODO: check if this is a good idea and if it even works as intendedChecklist
I have commented my codeI have written javadoc (required for public methods)I have added sufficient unit and API testsI have made corresponding changes to the documentationI have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.