-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement contributions/count[/density]/groupBy/boundary endpoints #230
Conversation
c5bb5a3
to
4bc908d
Compare
5273125
to
7167df4
Compare
7167df4
to
37ec1a8
Compare
.../ohsome/ohsomeapi/controller/dataaggregation/contributions/ContributionsCountController.java
Outdated
Show resolved
Hide resolved
.../ohsome/ohsomeapi/controller/dataaggregation/contributions/ContributionsCountController.java
Outdated
Show resolved
Hide resolved
.../ohsome/ohsomeapi/controller/dataaggregation/contributions/ContributionsCountController.java
Outdated
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/executor/ContributionsExecutor.java
Outdated
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/executor/ContributionsExecutor.java
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/executor/UsersRequestExecutor.java
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/output/Description.java
Outdated
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/output/Description.java
Outdated
Show resolved
Hide resolved
src/main/lombok/org/heigit/ohsome/ohsomeapi/output/Description.java
Outdated
Show resolved
Hide resolved
src/test/java/org/heigit/ohsome/ohsomeapi/controller/GetControllerTest.java
Show resolved
Hide resolved
We should check if we can increase the code coverage for the new/touched code, see here: https://sonarcloud.io/component_measures?branch=PR-230&id=org.heigit.ohsome%3Aohsome-api&metric=new_coverage&view=list |
b531874
to
6ff2a58
Compare
puh, not sure how much sense it would make to test the methods in the for the executor class: yeah, some paths are actually not covered, but AFAICS this is a general issue throughout our code. Instead of adding gazillions of test cases, it would be more beneficial to consolidate the code to a) reduce the code duplications, b) make the code more easily maintainable and c) be able to unit-test for example the output building of csv/json/geojson in a more centralized way. |
27a65ae
to
12c62d0
Compare
(suggestions from code review) Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
N.B. this feature was broken since at least version 1.6.0 for /users/groupBy/boundary and /elements/*/groupBy/boundary requests
c7fef7f
to
cc02a71
Compare
Description
/groupBy/boundary
versions of the/contributions/count[/density]
endpointsN.B. this feature was broken since at least version 1.6.0 for
/users/groupBy/boundary
and/elements/*/groupBy/boundary
requestsCorresponding issue
Closes #217. See also #115.
todo
Checklist
or created an issue in the corresponding repository. More Information here. -> https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/helpers/check-ohsome-api/-/commit/5a5f7640f4ff0e44ff16f3880608899c4f91ff5dchecked by @joker234