Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement contributions/count[/density]/groupBy/boundary endpoints #230

Merged
merged 15 commits into from
Sep 2, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Aug 19, 2021

Description

  • Adds /groupBy/boundary versions of the /contributions/count[/density] endpoints
  • fix handling of (deprecated) simplefeaturetypes filter (13d9945)
    N.B. this feature was broken since at least version 1.6.0 for /users/groupBy/boundary and /elements/*/groupBy/boundary requests

Corresponding issue

Closes #217. See also #115.

todo

  • write docs
  • implement integration tests
  • add to changelog
  • test functionality thoroughly
  • check if code coverage can be increased

Checklist

@tyrasd tyrasd added the enhancement New feature or request label Aug 19, 2021
@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch from c5bb5a3 to 4bc908d Compare August 19, 2021 16:06
@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch 2 times, most recently from 5273125 to 7167df4 Compare August 26, 2021 12:27
@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch from 7167df4 to 37ec1a8 Compare August 26, 2021 12:37
@tyrasd tyrasd changed the title 🚧 implement contributions/count[/density]groupBy/boundary endpoints implement contributions/count[/density]groupBy/boundary endpoints Aug 26, 2021
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Aug 26, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
docs/endpoints.rst Show resolved Hide resolved
docs/endpoints.rst Outdated Show resolved Hide resolved
@joker234 joker234 changed the title implement contributions/count[/density]groupBy/boundary endpoints implement contributions/count[/density]/groupBy/boundary endpoints Sep 1, 2021
@joker234 joker234 removed the waiting for review This pull request needs a code review label Sep 1, 2021
@joker234
Copy link
Member

joker234 commented Sep 1, 2021

We should check if we can increase the code coverage for the new/touched code, see here: https://sonarcloud.io/component_measures?branch=PR-230&id=org.heigit.ohsome%3Aohsome-api&metric=new_coverage&view=list

@joker234 joker234 added this to the 1.7 milestone Sep 1, 2021
@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch from b531874 to 6ff2a58 Compare September 2, 2021 08:18
@tyrasd
Copy link
Member Author

tyrasd commented Sep 2, 2021

We should check if we can increase the code coverage for the new/touched code, see here: https://sonarcloud.io/component_measures?branch=PR-230&id=org.heigit.ohsome%3Aohsome-api&metric=new_coverage&view=list

puh, not sure how much sense it would make to test the methods in the Description class. 🤷

for the executor class: yeah, some paths are actually not covered, but AFAICS this is a general issue throughout our code. Instead of adding gazillions of test cases, it would be more beneficial to consolidate the code to a) reduce the code duplications, b) make the code more easily maintainable and c) be able to unit-test for example the output building of csv/json/geojson in a more centralized way.

@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch from 27a65ae to 12c62d0 Compare September 2, 2021 10:36
CHANGELOG.md Outdated Show resolved Hide resolved
tyrasd and others added 3 commits September 2, 2021 12:55
(suggestions from code review)

Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
N.B. this feature was broken since at least version 1.6.0 for /users/groupBy/boundary and /elements/*/groupBy/boundary requests
@tyrasd tyrasd force-pushed the contributions-groupby-boundary branch from c7fef7f to cc02a71 Compare September 2, 2021 10:56
@tyrasd tyrasd requested a review from joker234 September 2, 2021 10:56
@tyrasd tyrasd merged commit 843a0c4 into master Sep 2, 2021
@tyrasd tyrasd deleted the contributions-groupby-boundary branch September 2, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement contributions/count/groupBy/boundary endpoint
2 participants