exclude log4j-api dependency from spring-boot #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker234
added
dependencies
joker234
force-pushed
the
exclude-log4j
branch
from
0384c4a to
2add40a
Compare
bonaparten
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
log4jwasn't used in the ohsome API. Thelog4j-apiis still loaded but not used without any configuration. Nevertheless we don't need this dependency and remove it.Corresponding issue
Related to CVE-2021-44228. More information from spring: https://spring.io/blog/2021/12/10/log4j2-vulnerability-and-spring-boot
New or changed dependencies
log4j-apidependency fromspring-boot-starter-web.Checklist
[ ] My code follows the code-style rules, and I have checked on the static analyses[ ] I have commented my code[ ] I have written javadoc (required for public methods)[ ] I have added sufficient unit and API tests[ ] I have made corresponding changes to the documentation[ ] I have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.