Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional informational badges to README #39

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Conversation

joker234
Copy link
Member

Add additional informational badges to README

Related to GIScience/oshdb#262 and GIScience/badges#2.

See https://github.com/GIScience/ohsome-api/tree/update-badges#ohsome-api for a preview.

@joker234 joker234 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 26, 2020
@joker234 joker234 requested review from tyrasd and FabiKo117 August 26, 2020 13:17
@joker234
Copy link
Member Author

One suggestion would be, that we could move the badges to the top. What do you think?

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 @FabiKo117: do you miss anything?

Copy link
Contributor

@FabiKo117 FabiKo117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like these badges too. I just browsed through some other GitHub projects and all of them either have the badges right next to the name in the top line, or directly under the name (like the ORS has it too).

The one right next to the name does not look that great imo, especially as we have several badges, but right under "ohsome API" would also fit.

@joker234
Copy link
Member Author

moved under the headline, rebased to master, can be merged

@joker234 joker234 requested a review from FabiKo117 August 27, 2020 09:22
@tyrasd tyrasd merged commit 13931ec into master Aug 27, 2020
@tyrasd tyrasd deleted the update-badges branch August 27, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants