Request executor refactoring #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabiKo117
changed the title
rtroilo
reviewed
Sep 14, 2020
There was a problem hiding this comment.
We peer-coded this change together but I unified the writeCsvResponse in the AggregateRequestExecutor afterwards. So @FabiKo117 can you please check this part again, so that we can approve this together.
rtroilo
approved these changes
Sep 15, 2020
for processing of aggregation endpoints under /elements and /elements/_/groupBy/boundary
replacing long variable declarations with keyword "var" moving some variable declarations closer to their point of initialization
used for /groupBy/boundary response creation changing name of class to better reflect the usage
FabiKo117
force-pushed
the
request-executor-refactoring
branch
from
b0c65a1 to
32895bb
Compare
bonaparten
pushed a commit
that referenced
this pull request
Sep 17, 2020
tyrasd
added
the
code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring of aggregate endpoint processing + groupBy/boundary
creating additional classes and removing unused methods
adding Java 11 specific keyword 'var' to some variables to reduce length of long variable declarations