Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delombok everything #90

Merged
merged 4 commits into from
Jan 8, 2021
Merged

delombok everything #90

merged 4 commits into from
Jan 8, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Jan 7, 2021

This uses the lombok-maven-plugin to delomboking all java classes.

It would technically suffice (I believe) to only put the classes which actually use the lombok annotations into the /src/main/lombok/ directory (and leave all "regular" classes in /src/main/java), but I guess this way is a bit easier to manage since then one would not have to think about the need to move files when starting to use lombok more and more.

TODO:

  • check if there are any references (in code comments, documentation, etc.) to /src/main/java which need to be updated

@tyrasd tyrasd added the documentation Improvements or additions to documentation label Jan 7, 2021
@tyrasd tyrasd changed the title delombok everything delombok everything (fixes missing getters/setters in javadoc) Jan 7, 2021
@tyrasd tyrasd requested review from joker234 and FabiKo117 January 7, 2021 17:54
@tyrasd tyrasd changed the title delombok everything (fixes missing getters/setters in javadoc) delombok everything Jan 7, 2021
@tyrasd tyrasd added this to the 1.3 milestone Jan 7, 2021
@tyrasd tyrasd merged commit 96fc156 into master Jan 8, 2021
@tyrasd tyrasd deleted the delombok branch January 8, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants