make sure groupByEntity is called before filters are set #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker234
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Resolves the addressed bug. Checked with check-ohsome-api and ohsome-api-outputcomparer.
@FabiKo117, do you want to have a look too?
I was following your discussions and it seems like you resolved it, so I don't have to. |
tyrasd
force-pushed
the
fix-extraction-filter
branch
from
e1d8268 to
aa84bb4
Compare
5 tasks
|
I can run the affected data-extraction tests then once I've updated them for #100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug in the implementation of the oshdb upgrade (to version 0.6) in #86